Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Azure Network module #631

Merged
merged 25 commits into from
Sep 30, 2020

Conversation

davesee
Copy link
Contributor

@davesee davesee commented Sep 15, 2020

Adding the following modules
Virtual Network and Subnet
Network Interface
Public IP Address

Adding the Terratest Network example to test these modules

Fixes #627

@rguthriemsft
Copy link
Contributor

Resolves #627

@rguthriemsft
Copy link
Contributor

@davesee
Copy link
Contributor Author

davesee commented Sep 24, 2020

@davesee
Copy link
Contributor Author

davesee commented Sep 25, 2020

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! Most comments are style nits. There is one substantial comment about returning the error in the Exists functions.

modules/azure/compute.go Outdated Show resolved Hide resolved
modules/azure/networkinterface.go Outdated Show resolved Hide resolved
modules/azure/networkinterface.go Outdated Show resolved Hide resolved
modules/azure/networkinterface.go Show resolved Hide resolved
modules/azure/publicaddress.go Show resolved Hide resolved
modules/azure/virtualnetwork.go Show resolved Hide resolved
modules/azure/virtualnetwork.go Show resolved Hide resolved
test/azure/terraform_azure_network_example_test.go Outdated Show resolved Hide resolved
test/azure/terraform_azure_network_example_test.go Outdated Show resolved Hide resolved
test/azure/terraform_azure_network_example_test.go Outdated Show resolved Hide resolved
@davesee
Copy link
Contributor Author

davesee commented Sep 28, 2020

@davesee
Copy link
Contributor Author

davesee commented Sep 29, 2020

@davesee
Copy link
Contributor Author

davesee commented Sep 30, 2020

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest updates LGTM! However, after checking the build log, I noticed that it is running the old version that doesn't have the terraform fmt check and modules unit tests.

Can you rebase and rerun the build so it does those checks?

@davesee
Copy link
Contributor Author

davesee commented Sep 30, 2020

Sorry about that @yorinasub17, the files were updated but I re-ran the earlier workflow ci-job. Here is a new run/pass with the fmt and unit tests:

https://github.com/rguthriemsft/terratest/runs/1187932044?check_suite_focus=true

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working through the fixes.

@yorinasub17 yorinasub17 merged commit 48e24df into gruntwork-io:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Azure Network module
3 participants