-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding Azure Network module #631
feat: adding Azure Network module #631
Conversation
Resolves #627 |
Here is the CI run for this pull request https://github.com/rguthriemsft/terratest/runs/1120097907?check_suite_focus=true |
…to pull-request-627
…to pull-request-627
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM! Most comments are style nits. There is one substantial comment about returning the error in the Exists
functions.
…to pull-request-627
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest updates LGTM! However, after checking the build log, I noticed that it is running the old version that doesn't have the terraform fmt
check and modules unit tests.
Can you rebase and rerun the build so it does those checks?
Sorry about that @yorinasub17, the files were updated but I re-ran the earlier workflow ci-job. Here is a new run/pass with the fmt and unit tests: https://github.com/rguthriemsft/terratest/runs/1187932044?check_suite_focus=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working through the fixes.
Adding the following modules
Virtual Network and Subnet
Network Interface
Public IP Address
Adding the Terratest Network example to test these modules
Fixes #627