Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding Azure Container Instances module #593

Merged
merged 8 commits into from
Aug 11, 2021

Conversation

polatengin
Copy link
Contributor

This PR is for adding Azure Container Instances module to the Terratest.

With this module, it can be possible to test Azure Container Instance resources on Terraform scripts.

```go
require (
...
github.com/Azure/azure-sdk-for-go v38.1.0+incompatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump to 46

@HadwaAbdelhalem
Copy link
Contributor

Hi @yorinasub17 , Please take a look when you get a chance. Here is a link to the related passed CI.

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor

I'll kick off a sanity check build and if it passes our precommit hooks, will merge.

@yorinasub17
Copy link
Contributor

The build passed the precommit phase, so will merge and release now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants