-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Azure FunctionApp Module #591
feat: add Azure FunctionApp Module #591
Conversation
Hi @yorinasub17, PR is updated and ready for your review. Here is the related CI. the failure in it is unrelated to the change, but it is due to Azure failure to create cosmos DB due to unavailability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just found one typo in the docs. I'll kick off a regression build now to make sure our precommit hooks run.
modules/azure/appService.go
Outdated
"github.com/stretchr/testify/require" | ||
) | ||
|
||
// AppExistsE indicates whether the specified application exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// AppExistsE indicates whether the specified application exists. | |
// AppExists indicates whether the specified application exists. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and sanity check build passed, so we can merge this in!
This PR is for adding Azure Function App module to the Terratest.
With this module, it can be possible to test Azure Function App resources on Terraform scripts.