Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Azure FunctionApp Module #591

Merged
merged 10 commits into from
Jul 16, 2021

Conversation

polatengin
Copy link
Contributor

This PR is for adding Azure Function App module to the Terratest.

With this module, it can be possible to test Azure Function App resources on Terraform scripts.

@polatengin polatengin changed the title Azure FunctionApp Module feat: add Azure FunctionApp Module Aug 31, 2020
@HadwaAbdelhalem
Copy link
Contributor

Hi @yorinasub17, PR is updated and ready for your review. Here is the related CI. the failure in it is unrelated to the change, but it is due to Azure failure to create cosmos DB due to unavailability

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just found one typo in the docs. I'll kick off a regression build now to make sure our precommit hooks run.

"github.com/stretchr/testify/require"
)

// AppExistsE indicates whether the specified application exists.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// AppExistsE indicates whether the specified application exists.
// AppExists indicates whether the specified application exists.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and sanity check build passed, so we can merge this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants