Implement a function for workspace selection, or creation #164
Conversation
A new function `WorkspaceSelectOrNew` has been implemented and covered via three unit tests.
modules/terraform/workspace.go
Outdated
| return out, nil | ||
| } | ||
|
|
||
| if strings.Contains(out, name) { |
There was a problem hiding this comment.
This seems error prone. If you have a workspace called foobar and you set name to foo, this will return true even though foo doesn't actually exist. I think you need to split the output into individual lines and loop over each line looking for an exact match to name. Note that the currently selected workspace may have an asterisk next to it, so it might require some extra cleaning.
There was a problem hiding this comment.
That's correct, I'll modify it.
|
|
||
| // WorkspaceSelectOrNew runs terraform workspace with the given options and returns workspace name. | ||
| // It tries to select a workspace with the given name, or it creates a new one if it doesn't exist. | ||
| func WorkspaceSelectOrNew(t *testing.T, options *Options, name string) string { |
There was a problem hiding this comment.
The return value is the name of the current workspace.
modules/terraform/workspace.go
Outdated
| _, err = RunTerraformCommandE(t, options, "workspace", "new", name) | ||
| } | ||
| if err != nil { | ||
| return out, nil |
|
@brikis98 Improved. |
| } | ||
|
|
||
| func nameMatchesWorkspace(name string, workspace string) bool { | ||
| match, _ := regexp.MatchString(fmt.Sprintf("^\\*?\\s*%s$", name), workspace) |
There was a problem hiding this comment.
Could you add a comment to explain what format you expect workspace to have? It'll make it easier to understand the regex.
Related to #163 (Terraform workspace support)
A new function
WorkspaceSelectOrNewhas been implemented and covered via three unit tests. The function takes a workspace name as an argument and: