Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tests fixes #1317

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Failing tests fixes #1317

merged 3 commits into from
Jun 29, 2023

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Jun 27, 2023 •
edited
Loading

Description

Included changes:

  • Updated Ubuntu image used in GCP tests to actual 2204 lts version.
  • Fixed aws provider version in terraform-aws-rds-example, version 5.x introduce incompatible changes

image

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Fixed GCP and terraform-aws-rds-example tests

Migration Guide

@denis256 denis256 changed the title [WIP] GCP tests fixes [WIP] Failing tests fixes Jun 27, 2023
@denis256 denis256 changed the title [WIP] Failing tests fixes Failing tests fixes Jun 28, 2023
@denis256 denis256 marked this pull request as ready for review June 28, 2023 22:58
@denis256 denis256 merged commit c79a759 into master Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infraredgirl infraredgirl infraredgirl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis256 @infraredgirl