-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Events in k8s module #1297
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package k8s | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/stretchr/testify/require" | ||
|
||
corev1 "k8s.io/api/core/v1" | ||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
|
||
"github.com/gruntwork-io/terratest/modules/testing" | ||
) | ||
|
||
// ListEvents will retrieve the Events in the given namespace that match the given filters and return them. This will fail the | ||
// test if there is an error. | ||
func ListEvents(t testing.TestingT, options *KubectlOptions, filters metav1.ListOptions) []corev1.Event { | ||
events, err := ListEventsE(t, options, filters) | ||
require.NoError(t, err) | ||
return events | ||
} | ||
|
||
// ListEventsE will retrieve the Events that match the given filters and return them. | ||
func ListEventsE(t testing.TestingT, options *KubectlOptions, filters metav1.ListOptions) ([]corev1.Event, error) { | ||
clientset, err := GetKubernetesClientFromOptionsE(t, options) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
resp, err := clientset.CoreV1().Events(options.Namespace).List(context.Background(), filters) | ||
if err != nil { | ||
return nil, err | ||
} | ||
return resp.Items, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
//go:build kubernetes | ||
// +build kubernetes | ||
|
||
// NOTE: we have build tags to differentiate kubernetes tests from non-kubernetes tests. This is done because minikube | ||
// is heavy and can interfere with docker related tests in terratest. Specifically, many of the tests start to fail with | ||
// `connection refused` errors from `minikube`. To avoid overloading the system, we run the kubernetes tests and helm | ||
// tests separately from the others. This may not be necessary if you have a sufficiently powerful machine. We | ||
// recommend at least 4 cores and 16GB of RAM if you want to run all the tests together. | ||
|
||
package k8s | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/stretchr/testify/require" | ||
|
||
v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
_ "k8s.io/client-go/plugin/pkg/client/auth" | ||
) | ||
|
||
func TestListEventsEReturnsNilErrorWhenListingEvents(t *testing.T) { | ||
t.Parallel() | ||
|
||
options := NewKubectlOptions("", "", "kube-system") | ||
events, err := ListEventsE(t, options, v1.ListOptions{}) | ||
require.Nil(t, err) | ||
require.Greater(t, len(events), 0) | ||
} | ||
|
||
func TestListEventsInNamespace(t *testing.T) { | ||
t.Parallel() | ||
|
||
options := NewKubectlOptions("", "", "kube-system") | ||
events := ListEvents(t, options, v1.ListOptions{}) | ||
require.Greater(t, len(events), 0) | ||
} | ||
|
||
func TestListEventsReturnsZeroEventsIfNoneCreated(t *testing.T) { | ||
t.Parallel() | ||
ns := "test-ns" | ||
|
||
options := NewKubectlOptions("", "", "") | ||
|
||
defer DeleteNamespace(t, options, ns) | ||
CreateNamespace(t, options, ns) | ||
|
||
options.Namespace = ns | ||
events := ListEvents(t, options, v1.ListOptions{}) | ||
require.Equal(t, 0, len(events)) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be helpful to have tests for
ListEvents
to track that in the future function will continue to workThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review @denis256 . I've done my tests with kubectl and it turns out that the events API doesn't return an error even if you provide the wrong namespace/filters.
That's why I rewrote the current tests to use the
ListEvents
function and also added a new test which makes sure thatListEventsE
returns anil
error. What do you think?