Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the check in IsDeploymentAvailable function. #1278

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

marcellmartini
Copy link
Contributor

Description

According to the documentation of Deployment complete status, the statuses that must be checked to validate that a deployment has been completed are:

  • Type: Progressing
  • Status: True
  • Reason: NewReplicaSetAvailable

Fixes #1277.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

  • Fixed IsDeploymentAvailable function.
  • Updated test related to IsDeploymentAvailable function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s.IsDeploymentAvailable() sometimes returning true even if de deployment is not complete
2 participants