Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add ability to get a random region for a specific service #1269

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

MoonMoon1919
Copy link
Contributor

Description

Adds ability to get a random region that is known to be supported for specific service. This avoids the scenario where a test using GetRandomRegion tries to create a resource in an AWS region where it may not be supported yet.

This is a convenience feature for consumers of this package who are testing a module containing a single resource (e.g., AWS Api Gateway V2) and who want to test the module in random regions.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added GetRandomRegionForService to support retrieving a random region that is supported for a specific AWS service.

Migration Guide

Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@MoonMoon1919 MoonMoon1919 merged commit e0c790c into master Apr 11, 2023
@MoonMoon1919 MoonMoon1919 deleted the feat/add-get-random-region-for-service branch April 11, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants