Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pod.Status.{Reason,Message} to PodNotAvailable error #1223

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Jan 6, 2023

Signed-off-by: Charly Molter [email protected]

When writing tests using terratest it's useful to figure why a pod
failed to start.

For example we use heavily terratest in our e2e suite. Some tests
are flaky for many possible reasons at the moment we have to switch to using:
WaitUntilPodAvailableE and use the error to get the pod status.

Fix #1222

Add extra info in the error message.

Read the Gruntwork contribution guidelines.

  • Update the docs. -- No docs for this
  • Run the relevant tests successfully, including pre-commit checks. -- Trying to figure out how to do this
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Added context to PodNotAvailable error to make troubleshooting easier.

Migration Guide

When writing tests using terratest it's useful to figure why a pod
failed to start.

For example we use heavily terratest in our e2e suite. Some tests
are flaky for many possible reasons at the moment we have to switch to using:
`WaitUntilPodAvailableE` and use the error to get the pod status.

Signed-off-by: Charly Molter <[email protected]>
@lahabana
Copy link
Contributor Author

@denis256 it seems like CI is failing for reasons unrelated to this PR. Can you help me please?

@denis256
Copy link
Member

Hello,
failing tests aren't related to implemented changes

@denis256 denis256 merged commit 599561b into gruntwork-io:master Jan 13, 2023
@lahabana lahabana deleted the addPodStatus branch January 13, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More context on error on WaitUntilPodAvailable
2 participants