Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kustomize argument for kubectl #1169

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

yufeiminds
Copy link
Contributor

@yufeiminds yufeiminds commented Aug 31, 2022

Description

Fixes #915.

Kustomize is supported by kubectl -k official. I use this in my work, I think it may be useful for others.

Kubectl has an older version of Kustomize?

It is older than most recent version, but it is good enough for me. I don't want to install another tools.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added Kustomize integration for k8s module.

Migration Guide

@yufeiminds yufeiminds changed the title [WIP] add kustomize argument for kubectl Add kustomize argument for kubectl Aug 31, 2022
Copy link
Member

@denis256 denis256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think will be good if changes will have some basic tests to keep track over time if Kustomize functions will continue to work

@yufeiminds
Copy link
Contributor Author

yufeiminds commented Sep 5, 2022

I think will be good if changes will have some basic tests to keep track over time if Kustomize functions will continue to work

Maybe I need your help to understand how to write and pass the test case in this repo. I have some questions:

  1. Test check failed, but the logs are 404 not found.
  2. Maybe I need a guide or example for contributors to understand how to run test cases locally without Github Actions.
  3. I found two files (unit test, example test). I will write a test case as example test. Is it correct?

Terratest is an awesome project for infrastructure testing, I want to improve it better. Can you help me? @denis256 😄

Copy link
Member

@denis256 denis256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes tests passed without failures 👍

@denis256 denis256 merged commit a4eeeab into gruntwork-io:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] k8s.KubectlKustomize (template generation)
2 participants