Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common list of GCP regions to avoid in tests #1133

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

denis256
Copy link
Member

Description

Extracted a common list of GCP regions that can't run f1-micro and n1-standard-1 instances, re-used created list in GCP tests.

Fixes #1132

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@denis256 denis256 changed the title Add common list of regions to avoid in GCP tests Common list of GCP regions to avoid in tests May 28, 2022
@denis256 denis256 self-assigned this May 28, 2022
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17 yorinasub17 merged commit acdc337 into master Jun 2, 2022
@yorinasub17 yorinasub17 deleted the bug/fix-gcp-regions branch June 2, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing GCP tests
2 participants