Get default aws subnet ids #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Etiene
requested review from
marinalimeira,
infraredgirl,
robmorgan and
ina-stoyanova
as code owners
denis256
previously approved these changes
May 28, 2022
modules/aws/vpc.go
Outdated
| } | ||
|
|
||
| for _, subnet := range vpc.Subnets { | ||
| if subnet.DefaultForAz == true { |
There was a problem hiding this comment.
I was wondering if is required to check for true
There was a problem hiding this comment.
oh yea, this is not necessary. removed in 864adce and added a new check in the tests for excluding recently created subnets too
denis256
approved these changes
Jun 2, 2022
|
Thanks for approving this @denis256! PS: I don't have the powers to re-run the CI tests nor merge PRs in this repo :) |
|
Kicked off test after rebasing on |
|
Confirmed the test failures are unrelated to this change, so will go ahead and merge + release this! |
|
@yorinasub17 Lovely, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1130.
The VPC object obtained when running aws.GetDefaultVpc includes all subnets in the default VPC, and not just the default subnets. This is a problem because often this is used with the intention to get the default subnets in a region, as by default the default VPC has a default subnet in each availability zone. However, there are occasions where more subnets are created in the default VPC causing unintended effects.
For example:
TestGetVpcsEsometimes fails due to unmatching AZ & subnet numberThis PR
aws.GetDefaultSubnetIDsForVpcto retrieve default subnet idsaws.IsPublicSubnetto check implicit association with the main route table in VPC when the subnet does not have any explicitly associated route tablesTestGetVpcsEtest to check for greater or equal number of subnets and availability zones instead of equal.TODOs
Read the Gruntwork contribution guidelines.
Release Notes
aws.GetDefaultSubnetIDsForVpcto retrieve default subnet idsaws.IsPublicSubnetto check implicit association with the main route table in VPC when the subnet does not have any explicitly associated route tables