Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken validate call for azure example #1123

Merged
merged 1 commit into from
May 23, 2022
Merged

Fix broken validate call for azure example #1123

merged 1 commit into from
May 23, 2022

Conversation

yorinasub17
Copy link
Contributor

@yorinasub17 yorinasub17 commented May 19, 2022 •
edited
Loading

This Azure example was failing the validate test due to a backward incompatibility update in the azure provider for the azurerm_frontdoor resource.

cc @HadwaAbdelhalem

@HadwaAbdelhalem
Copy link
Contributor

Thanks for fixing it @yorinasub17. I tested it locally and it LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit ab8a34b into master May 23, 2022
@yorinasub17 yorinasub17 deleted the bug/fix-broken-validate branch May 23, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 approved these changes

@marinalimeira marinalimeira Awaiting requested review from marinalimeira

@infraredgirl infraredgirl Awaiting requested review from infraredgirl

@robmorgan robmorgan Awaiting requested review from robmorgan

@ina-stoyanova ina-stoyanova Awaiting requested review from ina-stoyanova

Assignees
No one assigned
Labels
Azure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yorinasub17 @HadwaAbdelhalem @denis256