Include .terraform.lock.hcl in CopyTerraformFolderToDest #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds in the filter from the function CopyTerragruntFolderToDest an exclusion exception for the lock file. The `.terraform.lock.hcl` used by Terraform to lock the versions of the providers is not included during the copy. It can bring weird behaviors when the copy is skipped (check the function test_structure.CopyTerraformFolderToDest) where version 1.1 of a provider would be used in the example folder but might be updated during the `terraform init` due to the copy without the lock file. The lock file should be included within the copy to keep the same providers' versions. Fix: gruntwork-io#1116
Erouan50
requested review from
marinalimeira,
infraredgirl,
robmorgan and
ina-stoyanova
as code owners
yorinasub17
approved these changes
May 18, 2022
|
Build failed, but for a known failure on |
|
The updated build failed, but for a known failure from |
|
You're welcome, thank you! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds in the filter from the function
CopyTerragruntFolderToDest an exclusion exception for the lock file.
The
.terraform.lock.hclused by Terraform to lock the versions ofthe providers is not included during the copy. It can bring weird
behaviors when the copy is skipped (check the function
test_structure.CopyTerraformFolderToDest) where version 1.1 of a
provider would be used in the example folder but might be updated during
the
terraform initdue to the copy without the lock file. The lockfile should be included within the copy to keep the same providers'
versions.
Fix: #1116
I ran the test from the
modules/files. Here is the output:I try to run the tests from the
modules/terraform, but a lot of them fail(they fail as well from master) and don't seem to be related to my changes.