Add utility function for validating slack integrations #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
requested review from
marinalimeira,
infraredgirl,
robmorgan and
ina-stoyanova
as code owners
|
NOTE: I investigated the test failures and they don't seem to be related to this. In particular, the new test |
|
Thanks for review! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates one of our internal validation functions (from terraform-aws-monitoring) to
terratestso that it can be reused across out modules.The new function
slack.ValidateExpectedSlackMessageEcan be used to check if a particular message text has been posted by a bot in the given channel, which is useful for integration testing of slack based workflows.