Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP tests fixes #1065

Merged
merged 2 commits into from
Feb 24, 2022
Merged

GCP tests fixes #1065

merged 2 commits into from
Feb 24, 2022

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Feb 13, 2022

Noticed that GCP tests started to fail with errors like:

TestTerraformGcpInstanceGroupExample 2022-02-13T15:01:51Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: Error resolving image name 'ubuntu-os-cloud/ubuntu-1604-lts': Could not find image or family ubuntu-os-cloud/ubuntu-1604-lts

or

TestImportSSHKeyOSLogin 2022-02-13T20:14:34Z oslogin.go:101: Getting login profile for user [email protected]
    compute_test.go:205: Error launching new Compute Instance: googleapi: Error 400: Invalid value for field 'resource.machineType': 'zones/southamerica-west1-a/machineTypes/f1-micro'. Machine type with name 'f1-micro' does not exist in zone 'southamerica-west1-a'., invalid

Looks like ubuntu-1604 image is only in as "ubuntu-pro" with additional costs

https://user-images.githubusercontent.com/10694338/153772991-edb90b91-bcba-4c3e-9ee5-f969b4296ac2.png

Updated tests to use ubuntu-2004-lts image, removed region southamerica-west1 from tests since can't be deployed f1-micro instances there.

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yorinasub17
Copy link
Contributor

Merging so we can start to see these tests pass!

@yorinasub17 yorinasub17 merged commit a4675e3 into master Feb 24, 2022
@yorinasub17 yorinasub17 deleted the bug/gcp-tests-fix branch February 24, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants