Add functions useful for interacting with docker images and building remote images #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorinasub17
requested review from
marinalimeira,
infraredgirl,
robmorgan and
ina-stoyanova
as code owners
denis256
previously approved these changes
Feb 11, 2022
| @@ -60,3 +64,23 @@ func TestBuildWithTarget(t *testing.T) { | |||
| out := Run(t, tag, &RunOptions{Remove: true}) | |||
| require.Contains(t, out, text1) | |||
| } | |||
|
|
|||
| func TestGitCloneAndBuild(t *testing.T) { | |||
There was a problem hiding this comment.
t.Parallel() is missing by intention?
There was a problem hiding this comment.
Ah good catch! Was not intentional. Added in! 443f3f8
denis256
approved these changes
Feb 12, 2022
|
Thanks for review! Build failures are unrelated to this change, so will go ahead and merge this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few functions that are useful for interacting with docker images, and building remote images:
ListImagesfor listing images in the docker daemonDeleteImagefor cleaning up images in the docker daemonDoesImageExistfor checking whether a given image exists in the daemonGitCloneAndBuildfor building a docker image from a remote git repo