-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minikube, helm, and test kubernetes version #1051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eprecated chartmuseum
yorinasub17
requested review from
ina-stoyanova,
infraredgirl,
marinalimeira and
robmorgan
as code owners
January 27, 2022 18:49
denis256
previously approved these changes
Jan 27, 2022
.circleci/config.yml
Outdated
HELM_VERSION: v3.1.1 | ||
K8S_VERSION: v1.18.20 # Same as EKS | ||
MINIKUBE_VERSION: v1.22.0 | ||
HELM_VERSION: v3.7.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why not update to helm v3.8.0
(released 3 days ago)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly timing of the release. Updated in db6b708
denis256
approved these changes
Jan 27, 2022
Thanks for review! Merging in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the minikube, helm, and test kubernetes versions that are used in CircleCI. As a part of this, several outdated tests needed to be updated to work against a more modern Kubernetes version.