Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust "Host" via http helper #1016

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Conversation

estahn
Copy link
Contributor

@estahn estahn commented Oct 14, 2021

I would like to do this:

headers := map[string]string{"Host" : "gloo-running-7xhydj.foobar"}
code, result := http_helper.HTTPDo(t, "GET", "http://randomelb.elb.ap-southeast-2.amazonaws.com/", nil, headers, nil)

@estahn
Copy link
Contributor Author

estahn commented Oct 14, 2021

@robmorgan Can you have a look at this one?

Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution and apologies for the delay in reviewing this! I'll kick off a regression build and if it passes, we can merge this in.

@yorinasub17
Copy link
Contributor

The build failed, but for reasons unrelated to this change so I am comfortable merging this in. Thanks again for the contribution here!

@yorinasub17 yorinasub17 merged commit 3d69d62 into gruntwork-io:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants