Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Public IP address module not using sovereign client module #822

Closed
mjyeaney opened this issue Mar 24, 2021 · 2 comments
Closed

Azure Public IP address module not using sovereign client module #822

mjyeaney opened this issue Mar 24, 2021 · 2 comments
Labels
Azure

Comments

@mjyeaney
Copy link
Contributor

The public IP address testing modules need modified to support Azure sovereign environments (if configured). This will require:

  • Addition of new supporting methods in /modules/azure/client_factory.go for PublicIPAddress clients
  • Modifying /modules/azure/publicaddress*.go to call into client_factory.go to ensure client instances are properly configured.
  • Updating any tests impacted.

Will submit PR on this work when complete.
@mjyeaney mjyeaney mentioned this issue Mar 24, 2021
Closed
@mjyeaney mjyeaney mentioned this issue Apr 7, 2021
Closed
@HadwaAbdelhalem
Copy link
Contributor

@yorinasub17 would you please close it, addressed in this merged PR #897

@yorinasub17
Copy link
Contributor

Closing as done in #897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Azure
Projects
None yet
Milestone
No milestone
3 participants
@yorinasub17 @mjyeaney @HadwaAbdelhalem