Build target flag for docker module #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
approved these changes
Mar 10, 2021
|
There were some unrelated, transient test failures; we'll have to deal with those separately. The relevant tests passed, so merging! |
This was referenced Mar 11, 2021
Closed
Closed
chore(deps): bump github.com/gruntwork-io/terratest from 0.30.15 to 0.32.9
tharun208/kuma#62
Closed
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an implementation for the issue: #792
Adding an optional
--targetflag for build options. A bit modifiedDockerfileused for tests (does not break reverse-compatibility for other tests) and added an additional test to make sure that flag works.Gist with tests output within
modules/dockerpath: https://gist.github.com/ThelonKarrde/9eab7f3172edd8c71032e690618764e1