Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build targets in docker module as a separate BuildOption #792

Closed
ThelonKarrde opened this issue Feb 21, 2021 · 3 comments
Closed

Build targets in docker module as a separate BuildOption #792

ThelonKarrde opened this issue Feb 21, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@ThelonKarrde
Copy link
Contributor

I want to suggest putting the target parameter of the docker build command as a separate parameter in BuildOptions.
I understand and see the note that terratest does not support most of the build parameters, but since target allows you to do truly unit testing for the Dockerfile. I know that you can pass it as a parameter to OtherOptions, but I think put it as a separate argument will be very handy.

I can implement it on my own, but it shows in your contribution guide - let me know what you think about it :)
@brikis98 brikis98 added enhancement New feature or request help wanted labels Feb 26, 2021
@brikis98
Copy link
Member

Seems reasonable. PR welcome!

@ThelonKarrde ThelonKarrde mentioned this issue Feb 28, 2021
Merged
@ThelonKarrde
Copy link
Contributor Author

I think it can be closed :)

@brikis98
Copy link
Member

Indeed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brikis98 @ThelonKarrde