Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureRequest: Use AWS SSM client to send multiple commands #797

Closed
b-m-f opened this issue Feb 26, 2021 · 3 comments
Closed

FeatureRequest: Use AWS SSM client to send multiple commands #797

b-m-f opened this issue Feb 26, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@b-m-f
Copy link

b-m-f commented Feb 26, 2021

What I would like to do:

Why?

https://github.com/gruntwork-io/terratest/blob/master/modules/aws/ssm.go#L138 always creates a new client.

Since the output is truncated I currently have to split up some workloads and execute them in sequence. Every time a new client is created the connection has to be established and waited for.

Reusing the same client will drasitacally improve the speed.

Implementation Idea

New function executeCommand(t testing.TestingT, client *ssm.SSM, command string) (*CommandOutput, error) .

This can then be used in a loop without reestablishing the connection every time.

I could send a PR if this is something you guys/gals would like to include into the SSM module.

@brikis98 brikis98 added enhancement New feature or request help wanted labels Mar 22, 2021
@brikis98
Copy link
Member

This makes sense. A PR is welcome, thank you!

@danquack
Copy link

Believe this issue can probably be closed now with #924

@brikis98
Copy link
Member

Good point. Closing now as this was fixed in #924.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants