Skip to content

Commit

Permalink
Fix: the helm command runner
Browse files Browse the repository at this point in the history
  • Loading branch information
anoop2811 committed Oct 25, 2023
1 parent 50f2bb2 commit 2e57203
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion modules/helm/template.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ func RenderRemoteTemplateE(t testing.TestingT, options *Options, chartURL string
args = append(args, extraHelmArgs...)

// ... and add the name and chart at the end as the command expects
args = append(args, chartURL, releaseName)
args = append(args, releaseName, "--repo", chartURL)

// Finally, call out to helm template command
return RunHelmCommandAndGetStdOutE(t, options, "template", args...)
Expand Down
2 changes: 1 addition & 1 deletion test/helm_keda_remote_example_template_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func TestHelmKedaRemoteExampleTemplateRenderedDeployment(t *testing.T) {
// we want to assert that the template renders without any errors.
// Additionally, although we know there is only one yaml file in the template, we deliberately path a templateFiles
// arg to demonstrate how to select individual templates to render.
output := helm.RenderRemoteTemplate(t, options, "--repo https://kedacore.github.io/charts", releaseName, []string{"templates/metrics-server/deployment.yamll"})
output := helm.RenderRemoteTemplate(t, options, "https://kedacore.github.io/charts", releaseName, []string{"templates/metrics-server/deployment.yamll"})

// Now we use kubernetes/client-go library to render the template output into the Deployment struct. This will
// ensure the Deployment resource is rendered correctly.
Expand Down

0 comments on commit 2e57203

Please sign in to comment.