Skip to content

Commit

Permalink
revert back the ci yaml changes
Browse files Browse the repository at this point in the history
  • Loading branch information
sweanan committed Jun 13, 2023
1 parent 2623f81 commit 2e01363
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
ref: ${{ github.event.inputs.branch }}
- name: install golangci-lint binary
run: |
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./bin v1.53.2
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b ./bin v1.31.0
- name: lint modules/azure folder
id: azure_module_lint
run: |
Expand Down
15 changes: 5 additions & 10 deletions examples/azure/terraform-azure-aks-example/output.tf
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,19 @@ output "client_key" {
}

output "client_certificate" {
value = azurerm_kubernetes_cluster.k8s.kube_config.0.client_certificate
sensitive = true
value = azurerm_kubernetes_cluster.k8s.kube_config.0.client_certificate
}

output "cluster_ca_certificate" {
value = azurerm_kubernetes_cluster.k8s.kube_config.0.cluster_ca_certificate
sensitive = true
value = azurerm_kubernetes_cluster.k8s.kube_config.0.cluster_ca_certificate
}

output "cluster_username" {
value = azurerm_kubernetes_cluster.k8s.kube_config.0.username
sensitive = true
value = azurerm_kubernetes_cluster.k8s.kube_config.0.username
}

output "cluster_password" {
value = azurerm_kubernetes_cluster.k8s.kube_config.0.password
sensitive = true
value = azurerm_kubernetes_cluster.k8s.kube_config.0.password
}

output "kube_config" {
Expand All @@ -28,6 +24,5 @@ output "kube_config" {
}

output "host" {
value = azurerm_kubernetes_cluster.k8s.kube_config.0.host
sensitive = true
value = azurerm_kubernetes_cluster.k8s.kube_config.0.host
}
6 changes: 3 additions & 3 deletions modules/azure/region.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"context"

"github.com/gruntwork-io/terratest/modules/collections"
// "github.com/gruntwork-io/terratest/modules/logger"
"github.com/gruntwork-io/terratest/modules/logger"
"github.com/gruntwork-io/terratest/modules/random"
"github.com/gruntwork-io/terratest/modules/testing"
)
Expand Down Expand Up @@ -115,7 +115,7 @@ func GetRandomRegionE(t testing.TestingT, approvedRegions []string, forbiddenReg
regionsToPickFrom = collections.ListSubtract(regionsToPickFrom, forbiddenRegions)
region := random.RandomString(regionsToPickFrom)

// logger.Logf(t, "Using region %s", region)
logger.Logf(t, "Using region %s", region)
return region, nil
}

Expand All @@ -138,7 +138,7 @@ func GetAllAzureRegions(t testing.TestingT, subscriptionID string) []string {

// GetAllAzureRegionsE gets the list of Azure regions available in this subscription
func GetAllAzureRegionsE(t testing.TestingT, subscriptionID string) ([]string, error) {
// logger.Log(t, "Looking up all Azure regions available in this account")
logger.Log(t, "Looking up all Azure regions available in this account")

// Validate Azure subscription ID
subscriptionID, err := getTargetAzureSubscription(subscriptionID)
Expand Down

0 comments on commit 2e01363

Please sign in to comment.