Stacks: run #3762
Merged
Stacks: run #3762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhakbar
reviewed
Jan 16, 2025
| func generateStack(ctx context.Context, opts *options.TerragruntOptions) error { | ||
| opts.TerragruntStackConfigPath = filepath.Join(opts.WorkingDir, defaultStackFile) | ||
| opts.Logger.Infof("Generating stack from %s", opts.TerragruntStackConfigPath) |
There was a problem hiding this comment.
Does this need to be in info?
There was a problem hiding this comment.
Without an info message, it is not clear what is happening, the user doesn't see any message and it is not clear which units got processed
yhakbar
reviewed
Jan 16, 2025
| if err := os.MkdirAll(baseDir, dirPerm); err != nil { | ||
| return errors.New(fmt.Errorf("failed to create base directory: %w", err)) | ||
| } | ||
|
|
||
| for _, unit := range stackFile.Units { | ||
| opts.Logger.Infof("Processing unit %s", unit.Name) |
There was a problem hiding this comment.
Does this need to be in info?
yhakbar
reviewed
Jan 16, 2025
yhakbar
reviewed
Jan 16, 2025
yhakbar
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Included changes:
stack run *commandstack runfunctionalityRFC: #3313
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide