Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold docs update #3512

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Scaffold docs update #3512

merged 3 commits into from
Oct 25, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Oct 22, 2024 •
edited
Loading

Description

Updated documentation for scaffold command for fetching external template

Fixes #3511.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@denis256 denis256 marked this pull request as ready for review October 22, 2024 16:44
levkohimins
levkohimins approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@denis256 denis256 merged commit a55ed8c into main Oct 25, 2024
4 of 5 checks passed
@denis256 denis256 deleted the bug/docs-update-3511 branch October 25, 2024 18:00
@BrewTestBot BrewTestBot mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levkohimins levkohimins levkohimins approved these changes

@yhakbar yhakbar Awaiting requested review from yhakbar yhakbar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scaffold appears broken using exact call from docs, leveraging external template.
2 participants
@denis256 @levkohimins