Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect engine messages to stderr #3468

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Redirect engine messages to stderr #3468

merged 4 commits into from
Oct 11, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Oct 10, 2024

Description

Included changes:

  • added redirecting of engine outputs
  • updated engine tests

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@denis256 denis256 changed the title Add option to redirect stdout to stderr for engine invocation Redirect engine messages to stderr Oct 10, 2024
@denis256 denis256 marked this pull request as ready for review October 10, 2024 20:43
Copy link
Contributor

@levkohimins levkohimins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@denis256 denis256 merged commit af89a98 into main Oct 11, 2024
5 checks passed
@denis256 denis256 deleted the tg-engine-log-level branch October 11, 2024 05:59
yhakbar added a commit that referenced this pull request Oct 15, 2024
* fix: modules output corruption

* chore: fix strict lint

* chore: fix fmt

* chore: fix tests

* chore: fix tests

* chore: fix tests

* chore: fix tests

* chore: fix tests

* chore: fix tests

* chore: update testdata

* fix: Removing non non-interactive logic in err stream redirect (#3464)

* chore: revert code

* Redirect engine messages to stderr (#3468)

* Add option to redirect stdout to stderr

* Engine tests update

* Tests update

* Lint issues update

* chore: log message

* chore: revert testdatda

---------

Co-authored-by: Yousif Akbar <[email protected]>
Co-authored-by: Denis O <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants