Google Cloud impersonate fixes #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonMoon1919
approved these changes
Aug 21, 2023
2 tasks
hugorut
pushed a commit
to infracost/terragrunt
that referenced
this pull request
Oct 10, 2023
* Migration of impersonate changes * Add test for bucket creation * Add replacement of email * acl item * add logging of acl * Testing gcp fix * object fetching test * Testing iam printing * testing ProjectTeam * Notifications * add log printing * Add test output value * Add function to read objects metadata * acl email * Add check for gcp acl * Tests cleanup * Tests cleanup * Removed debug prints * Added loop termination
hugorut
pushed a commit
to infracost/terragrunt
that referenced
this pull request
Oct 10, 2023
* Migration of impersonate changes * Add test for bucket creation * Add replacement of email * acl item * add logging of acl * Testing gcp fix * object fetching test * Testing iam printing * testing ProjectTeam * Notifications * add log printing * Add test output value * Add function to read objects metadata * acl email * Add check for gcp acl * Tests cleanup * Tests cleanup * Removed debug prints * Added loop termination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Included changes:
Fixes #1997.
Fixes #2477.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Addressed the issue related to GCP impersonation during state bucket creation.
Migration Guide
N/A