Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce run-all to replace xxx-all #1520

Merged
merged 10 commits into from
Feb 2, 2021
Merged

Introduce run-all to replace xxx-all #1520

merged 10 commits into from
Feb 2, 2021

Conversation

yorinasub17
Copy link
Contributor

Implements #492

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner January 29, 2021 22:03
@yorinasub17 yorinasub17 mentioned this pull request Jan 29, 2021
Closed
brikis98
brikis98 reviewed Feb 1, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work Yori!

cli/cli_app.go Show resolved Hide resolved
cli/cli_app.go Outdated Show resolved Hide resolved
configstack/stack.go Outdated Show resolved Hide resolved
brikis98
brikis98 previously approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few NITs for you to resolve or ignore as you choose.

cli/cli_app.go Outdated Show resolved Hide resolved
cli/cli_app.go Show resolved Hide resolved
cli/cli_app.go Show resolved Hide resolved
@yorinasub17 yorinasub17 mentioned this pull request Feb 2, 2021
Merged
@yorinasub17 yorinasub17 force-pushed the yori-run-all branch 2 times, most recently from bc6f70b to 7f4d53a Compare February 2, 2021 15:42
@yorinasub17
Copy link
Contributor Author

@brikis98 Ok addressed comments and sanity checks, and rebased + resolved merge conflicts. I think this is ready for a final review!

@yorinasub17
Copy link
Contributor Author

yorinasub17 commented Feb 2, 2021 •
edited
Loading

UPDATE: Fixed broken build in bc4eba9 . Not sure why this works on master, but in any case, this fixes a bug from #1510 where the LogLevel is set to PanicLevel when the TerragruntOptions struct is Cloned.

brikis98
brikis98 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work Yori 👍

@yorinasub17
Copy link
Contributor Author

Thanks for the review! Merging and releasing now!

@yorinasub17 yorinasub17 merged commit 7b2e875 into master Feb 2, 2021
@yorinasub17 yorinasub17 deleted the yori-run-all branch February 2, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brikis98 brikis98 brikis98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorinasub17 @brikis98