Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Optionally added separate secondary range for services. #86

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

Eugst
Copy link
Contributor

@Eugst Eugst commented Mar 30, 2020

Fixes #52

added var.services_secondary_range_name

@Eugst
Copy link
Contributor Author

Eugst commented Mar 31, 2020

@robmorgan @yorinasub17 Any luck to hear from you soon?

Copy link
Contributor

@robmorgan robmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. Some minor feedback from me.

modules/gke-cluster/variables.tf Outdated Show resolved Hide resolved
modules/gke-cluster/main.tf Outdated Show resolved Hide resolved
@Eugst Eugst requested a review from robmorgan March 31, 2020 16:14
@Eugst
Copy link
Contributor Author

Eugst commented Mar 31, 2020

@robmorgan fixed!

@robmorgan
Copy link
Contributor

@Eugst thanks, I've kicked off a build in: https://circleci.com/gh/gruntwork-io/terraform-google-gke/447

@Eugst
Copy link
Contributor Author

Eugst commented Apr 2, 2020

Super! Thank you @robmorgan
looking forward for new release.

@robmorgan
Copy link
Contributor

Ok tests pass, merging.

@robmorgan robmorgan merged commit 146c289 into gruntwork-io:master Apr 2, 2020
@Eugst
Copy link
Contributor Author

Eugst commented Apr 2, 2020

when expect 0.4.3? :)

@robmorgan
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster services/pods secondary subnets overlap causing service IP issues.
2 participants