This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
Use Stackdriver Kubernetes Engine Monitoring as default instead of Legacy Stackdriver #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileykarson
requested review from
autero1,
robmorgan and
yorinasub17
as code owners
+1 |
autero1
approved these changes
Jun 3, 2019
robmorgan
approved these changes
Jun 3, 2019
| description = "The logging service that the cluster should write logs to. Available options include logging.googleapis.com, logging.googleapis.com/kubernetes (beta), and none" | ||
| default = "logging.googleapis.com" | ||
| description = "The logging service that the cluster should write logs to. Available options include logging.googleapis.com/kubernetes, logging.googleapis.com (legacy), and none" | ||
| default = "logging.googleapis.com/kubernetes" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
This was released as GA on May 20th. It will become the default logging / monitoring service for GKE beginning in
1.14.Xseries releases, which will go GA ~3 months after1.13.X(May 13th).As I understand it, this isn't a breaking change for Kubernetes, but is for Stackdriver as the cluster will output different fields. We should probably bump our minor version based on that, or hold this is a default until later.