-
Notifications
You must be signed in to change notification settings - Fork 282
Conversation
I know we've been doing this for all our repos, but should we remove the tf code in the example folder so that there is only one copy of the example that ends up in the root? |
I slightly prefer to keep tf code in the examples folder too, but keeping a single copy would be nice. No strong feelings from me. |
I forget: Does terraform work with symlinks? Could we symlink the example folder tf files to the root ones? |
That way the relative references to modules won't work in both locations. |
Ah that makes sense. Bummer! |
I like the idea of keeping only a single copy of the examples. This is how it was done for the Influx -modules: https://github.com/gruntwork-io/terraform-aws-influx/tree/master/examples/influxdb-cluster-simple. Documentation and "extras" in the example folder but the tf files only in the root. |
Amended to follow what the influx module does. |
The tests will most likely break now that the examples folder doesn't contain the tf -files. |
Yeah, I didn't add a test on that folder past testing locally because tests don't run in parallel so we'd be adding another 20+ minutes onto tests that are already quite long. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.