This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
Use network module #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing ATM due to CircleCI machine user cannot pull the network module. Once that's fixed, the tests should pass. |
Use the network -module in the other examples. Improved documentation.
rileykarson
approved these changes
Apr 11, 2019
| @@ -42,7 +42,20 @@ Currently, you cannot use a proxy to reach the cluster master of a regional clus | |||
| 1. Run `terraform get`. | |||
| 1. Run `terraform plan`. | |||
| 1. If the plan looks good, run `terraform apply`. | |||
|
|
|||
| #### Optional: Deploy a sample application | |||
| @@ -65,17 +65,22 @@ provider "helm" { | |||
| module "gke_cluster" { | |||
| # When using these modules in your own templates, you will need to use a Git URL with a ref attribute that pins you | |||
| # to a specific version of the modules, such as the following example: | |||
| # source = "git::[email protected]:gruntwork-io/gke-cluster.git//modules/gke-cluster?ref=v0.0.1" | |||
| # source = "git::[email protected]:gruntwork-io/terraform-google-gke.git//modules/gke-cluster?ref=v0.0.5" | |||
There was a problem hiding this comment.
Suggested change
| # source = "git::[email protected]:gruntwork-io/terraform-google-gke.git//modules/gke-cluster?ref=v0.0.5" | |
| # source = "git::[email protected]:gruntwork-io/terraform-google-gke.git//modules/gke-cluster?ref=v0.0.4" |
We're at 0.0.4, right? I see both 4 and 5 across our references.
There was a problem hiding this comment.
I changed all of those to point to v0.0.5 which is the upcoming release after this PR is merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the Google network module into use and adds a sample deployment step in the private cluster example.
Note that merging requires resolving gruntwork-io/terraform-google-network#16