Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

Add basic Helm on GKE example #15

Merged
merged 16 commits into from
Feb 28, 2019
Merged

Add basic Helm on GKE example #15

merged 16 commits into from
Feb 28, 2019

Conversation

robmorgan
Copy link
Contributor

@robmorgan robmorgan commented Feb 21, 2019

This PR adds a basic example of how to install Helm onto a GKE cluster.

Features

  • Stop hard-coding the [email protected] IAM account
  • Deploy a test Helm chart.
  • Verify that Nginx or whatever chart is listening on a port.
    Use different config files and run tests in parallel.

@yorinasub17
Copy link
Contributor

QQ: c610250

What was the reason for disabling the parallel testing? We should document this so that folks are aware of the gotcha, and make it easier to figure out a fix later.

@robmorgan robmorgan changed the title [WIP] Add basic Helm on GKE example Add basic Helm on GKE example Feb 26, 2019
@yorinasub17
Copy link
Contributor

What was the reason for disabling the parallel testing? We should document this so that folks are aware of the gotcha, and make it easier to figure out a fix later.

For posterity, the reason is because of conflicting kubectl configs. This is a limitation in the current terratest functions. I will be working on a fix, but to avoid blocking the release/merge, we should go ahead with the current version. Looking at CircleCI, this is still 30 mins which is on the borderline of what is "acceptable".

Does that sound reasonable team? (@robmorgan @rileykarson @autero1 ). If that sounds good, please add a comment around the commented out t.Parallel with the above note.

@autero1
Copy link
Contributor

autero1 commented Feb 28, 2019

Does that sound reasonable team?

Sounds good to me!

@robmorgan
Copy link
Contributor Author

Does that sound reasonable team?

Sounds good to me!

Yep, I agree, lets ship and revisit when we work on the private cluster support. By then the updates methods will be in Terratest. 👍

@robmorgan robmorgan merged commit b90352e into master Feb 28, 2019
@robmorgan robmorgan deleted the basic-helm branch February 28, 2019 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants