[WIP] Better cluster tests #12
Conversation
| @@ -4,8 +4,19 @@ output "cluster_endpoint" { | |||
| value = "${module.gke_cluster.endpoint}" | |||
| } | |||
|
|
|||
| output "client_certificate" { | |||
There was a problem hiding this comment.
It's my understanding that we've disabled this type of auth and these outputs won't do anything?
|
The code LGTM. We still have to figure out why the copy isn't working as expected. |
| # required for gcloud and kubectl to authenticate correctly | ||
| echo $GCLOUD_SERVICE_KEY | gcloud auth activate-service-account --key-file=- | ||
| gcloud --quiet config set project ${GOOGLE_PROJECT_ID} | ||
| gcloud --quiet config set compute/zone ${GOOGLE_COMPUTE_ZONE} |
There was a problem hiding this comment.
Do we need a zone set specifically, or do we really want a region?
There was a problem hiding this comment.
I swear something was failing if only the project was set. I added zone and it worked, but I didn't try region. Could test it.
| output "cluster_ca_certificate" { | ||
| description = "The public certificate that is the root of trust for the cluster. Encoded as base64." | ||
| description = "The public certificate that is the root of trust for the cluster." |
There was a problem hiding this comment.
It's likely still worth noting that these are base64'ed so users know to decode them to use them.
There was a problem hiding this comment.
I think technically I actually decode them now directly in the module, which may or may not be a good idea.
…vate clusters. Minor wording changes.
Co-Authored-By: rileykarson <[email protected]>
add working circleci config
robmorgan
force-pushed
the
better-cluster-tests
branch
from
41d832b to
462bb06
Compare
This PR expands the GKE tests to check the health of the Kubernetes cluster.