This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GKE Module Design #1
GKE Module Design #1
Changes from 1 commit
d2fa373
f8caca8
1deea1a
3e8a0d9
f081fe1
bcd5288
80e7533
7c48e39
14435b9
a5405ec
62ca09b
a83fa51
a410079
06e7633
25452bf
8d817cc
6718373
5a58c56
61eb7c5
eed633b
627d58a
f4ebb09
f4c7520
981452c
8d0ac51
f8f3e9b
aa783e3
a895a81
ac3ed78
4041c96
3f8c90c
b9be14f
263bdda
8c5cbb1
7746681
9fe4b2f
d1fef5c
8824e42
12e4210
34e500c
f983b35
9b833c0
cac6051
3299135
462bb06
8103773
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This datasource is present at the bottom of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for context, the reason this / the corresponding datasource are useful (https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/3f7527e583ffa07e6a06250844e07c38556a4488/cluster_regional.tf#L29) is because it lets you explicitly define which zones in the region your regional / multi-zonal (afaik regional supersedes multi-zonal) cluster resides in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A regional cluster doesn't necessarily support the same version(s) as any/all of its corresponding zones. We'll need to supply the
region
parameter when working with regional clusters.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the outputs from https://github.com/gruntwork-io/terraform-google-gke/pull/10/files#diff-c49d0ae81c71a97455954c7c48bc0eca without the
base64decode
step? I think they'll be necessary when integrating Tiller.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as dashboard - these are always user supplied (logging, monitoring).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an output we don't need, since the user will have supplied this variable anyways. Or is that standard convention?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah can probably go, I must have copied it from the other repos.