Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support flags #92

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Support flags #92

merged 1 commit into from
Apr 24, 2024

Conversation

autero1
Copy link
Contributor

@autero1 autero1 commented Apr 16, 2024

Description

Fixes #91

Properly handle flags when processing --module-param. Previously a flag that was passed like this: --module-param flag ended up like this: --flag flag. With this change it is properly passed as just --flag.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if it's not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

Copy link
Contributor

@robmorgan robmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

p.s I found one else statement on line 164, that could be pushed back one backspace but its unrelated to this PR!

offender:

elif [[ -n "$sha512_checksum" ]]; then

@autero1 autero1 merged commit 67d6b51 into main Apr 24, 2024
3 checks passed
@autero1 autero1 deleted the fix/mixed-args branch April 24, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken module parameters parsing
2 participants