Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old default branch references. #81

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Update old default branch references. #81

merged 2 commits into from
Aug 24, 2022

Conversation

rhoboat
Copy link
Contributor

@rhoboat rhoboat commented Aug 23, 2022

Description

Addresses part of https://github.com/gruntwork-io/cloud-chasers/issues/32

We've updated the default branch to main. This PR updates all the references in this repo to the new correct ones.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated old default branch references as we've switched to main.

yorinasub17
yorinasub17 previously approved these changes Aug 23, 2022
Copy link
Contributor

@yorinasub17 yorinasub17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spotted a few docs faults, but other than that LGTM

@rhoboat rhoboat force-pushed the feature/main-branch branch 4 times, most recently from 1b9bcbd to c60fc69 Compare August 23, 2022 19:42
@rhoboat rhoboat force-pushed the feature/main-branch branch from c60fc69 to 0afd6bd Compare August 23, 2022 19:43
echo " One-liner to download this bootstrap script from GitHub and run it to install version 0.0.3:"
echo " curl -Ls https://raw.githubusercontent.com/gruntwork-io/gruntwork-installer/master/bootstrap-gruntwork-installer.sh | bash /dev/stdin --version 0.0.3"
echo " One-liner to download this bootstrap script from GitHub and run it to install version v0.0.38:"
echo " curl -Ls https://raw.githubusercontent.com/gruntwork-io/gruntwork-installer/v0.0.38/bootstrap-gruntwork-installer.sh | bash /dev/stdin --version v0.0.38"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that passing in 0.0.38 doesn't work.

@rhoboat rhoboat requested a review from yorinasub17 August 23, 2022 19:45
@rhoboat
Copy link
Contributor Author

rhoboat commented Aug 23, 2022

Ready for another pass! @yorinasub17

@rhoboat
Copy link
Contributor Author

rhoboat commented Aug 24, 2022

Thanks Denis! Merging.

@rhoboat rhoboat merged commit a92c1c1 into main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants