Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap-gruntwork-installer.sh #75

Merged
merged 3 commits into from
Jun 16, 2022

Conversation

iancoralogix
Copy link
Contributor

@iancoralogix iancoralogix commented Jun 16, 2022

Description

The header of the bootstrap script uses an older tag as an example:

$ curl -Ls https://raw.githubusercontent.com/gruntwork-io/gruntwork-installer/master/bootstrap-gruntwork-installer.sh | bash /dev/stdin --version 0.0.3

Installing gruntwork-install version 0.0.3 to /usr/local/bin/gruntwork-install

What we want to see is:

$ curl -Ls https://raw.githubusercontent.com/gruntwork-io/gruntwork-installer/master/bootstrap-gruntwork-installer.sh | bash /dev/stdin --version v0.0.38
Installing gruntwork-install version v0.0.38 to /usr/local/bin/gruntwork-install

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

Copy link
Contributor

@rhoboat rhoboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for these improvements! ❤️

@iancoralogix iancoralogix merged commit 105ff2b into master Jun 16, 2022
@iancoralogix iancoralogix deleted the ib/update-bootstrap-oneliner branch June 16, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants