Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix aarch64 fetch install #70

Merged
merged 3 commits into from
Nov 16, 2021
Merged

fix aarch64 fetch install #70

merged 3 commits into from
Nov 16, 2021

Conversation

harrymilne
Copy link
Contributor

@harrymilne harrymilne commented Nov 13, 2021 •
edited
Loading

Problem

  • uname -m returns aarch64 on EKS ARM AMIs which causes get_os_arch_gox_format to return amd64 rather than arm64
  • fetch 0.4.1 has no ARM build

Solution

  • add case for aarch64 returning arm64
  • bump fetch version

Tested on x86 + ARM builds

@harrymilne harrymilne marked this pull request as ready for review November 13, 2021 03:57
@bwhaley
Copy link
Contributor

bwhaley commented Nov 15, 2021

Thanks @harrymilne! Just kicked off the tests.

@bwhaley
Copy link
Contributor

bwhaley commented Nov 16, 2021

Tests passed! Thanks for the contribution.

@bwhaley bwhaley merged commit e4eb89e into gruntwork-io:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackproser zackproser zackproser approved these changes

@bwhaley bwhaley bwhaley approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98 brikis98 is a code owner

@yorinasub17 yorinasub17 Awaiting requested review from yorinasub17

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harrymilne @bwhaley @zackproser