Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use arm64 if arm64 #67

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Use arm64 if arm64 #67

merged 1 commit into from
Aug 10, 2021

Conversation

yorinasub17
Copy link
Contributor

Previously we were assuming amd64 if the arch string contained 64, but this ignores arm64 machines like M1 macbook. This fixes that.

@yorinasub17 yorinasub17 requested a review from brikis98 as a code owner August 9, 2021 21:16
robmorgan
robmorgan approved these changes Aug 10, 2021
View reviewed changes
bootstrap-gruntwork-installer.sh Show resolved Hide resolved
@robmorgan
Copy link
Contributor

LGTM!

@yorinasub17
Copy link
Contributor Author

Thanks for review! Merging now.

@yorinasub17 yorinasub17 merged commit a376f14 into master Aug 10, 2021
@yorinasub17 yorinasub17 deleted the yori-arm64 branch August 10, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robmorgan robmorgan robmorgan approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98 brikis98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorinasub17 @robmorgan