Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error if release tag is not found #110

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Return error if release tag is not found #110

merged 1 commit into from
Aug 3, 2022

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Aug 2, 2022 •
edited
Loading

Description

Updated logic of release asset downloading to throw an error if release is not found

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
  • Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
  • Run the relevant tests successfully.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

Fixes gruntwork-io/gruntwork-installer#79

zackproser
zackproser approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@zackproser zackproser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@denis256 denis256 merged commit ebabfd6 into master Aug 3, 2022
@denis256 denis256 deleted the bug/check-download-asset-error branch August 3, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zackproser zackproser zackproser approved these changes

@brikis98 brikis98 Awaiting requested review from brikis98 brikis98 is a code owner

@yorinasub17 yorinasub17 Awaiting requested review from yorinasub17

@rhoboat rhoboat Awaiting requested review from rhoboat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve messaging around a non-existent tag
2 participants
@denis256 @zackproser