-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform direct asset name comparison #102
Conversation
I kicked off the build and it passed on CI! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the PR! Could you add some testing around this so it doesn't break again in the future? Would be good to test with various names too as a check this really fixes the issue.
@brikis98 is there a repo where it'll be okay to upload multiple release assets to help with testing? I don't want to pollute any of our actual repos. |
It would make sense to use these: Do you have access to these @tonerdo ? (credit to @yorinasub17) |
@rhoboat I don't have access to create new releases on https://github.com/gruntwork-io/fetch-test-public. I don't have access to https://github.com/gruntwork-io/fetch-test-private at all |
50a5911
to
e0de972
Compare
@brikis98 I was only able to add a test for an asset with the |
Description
Handle situations where the release asset name contains regex symbols that could mess up matching.
Documentation
TODOs
Please ensure all of these TODOs are completed before asking for a review.
feature/new-vpc-endpoints-955
orbug/missing-count-param-434
.Related Issues
Fixes #93