Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply un-used custom timeout value and update readme file #317

Closed
wants to merge 1 commit into from
Closed

apply un-used custom timeout value and update readme file #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,18 @@ Default: `false`

Display a list of all failed tests and their failure messages

#### options.allowFileAccess
Type: `Boolean`
Default: `false`

Launches puppeteer with --allow-file-access-from-files (Fix Issue https://github.com/gruntjs/grunt-contrib-jasmine/issues/298)

#### options.timeout
Type: `Number`
Default: `30000`

Change the puppeteer default timeout value in milliseconds (reference: https://github.com/puppeteer/puppeteer/blob/master/docs/api.md#pagesetdefaulttimeouttimeout)

### Flags

Name: `build`
Expand Down
3 changes: 2 additions & 1 deletion tasks/jasmine.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ module.exports = function(grunt) {
// Merge task-specific options with these defaults.
var options = this.options({
version: 'latest',
timeout: 10000,
timeout: 30000,
styles: [],
specs: [],
helpers: [],
Expand Down Expand Up @@ -165,6 +165,7 @@ module.exports = function(grunt) {

try {
await setup(options, dispatcher, page);
page.setDefaultTimeout(options.timeout);
await page.goto(file, { waitUntil: 'domcontentloaded' });

await jasminePromise;
Expand Down