Added errorhandler to convert errors to exceptions

[harmenjanssen]

This is a followup to the discussion in issue #27.
All PHP errors that can be handled with set_error_handler are
converted to Garp_Exception_RuntimeException instances of the correct
severity.

This makes sure not even a notice slips through.

‼️ Let's not merge this immediately by the way, but pick a project to run this in for a while and see what turns up in production.

[aapit]

LGTM!
It's hard to spot any flaky syntax or whatever like that at this point, but this is a very good idea in general.

[aapit]

Are we running this one somewhere yet?

[harmenjanssen]

No, we're not. Hmm.
I have tried it in a Twig project a while ago and got hammered with deprecation notices from the Twig library.

Anyways, that's not to say we shouldn't do it, but it'll need some attention probably to keep errors down a bit.

[aapit]

Can you book some time for this? No rush, but it would be good to have it planned.

[harmenjanssen]

Certainly. Harmen Janssen 2017-05-24 13:53 GMT+02:00 David Spreekmeester <[email protected]>:

…

Can you book some time for this? No rush, but it would be good to have it planned. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAxBaKwzBX45AX8wZ7q9f_TGRKwC5qGtks5r9BpXgaJpZM4MOSRF> .

[harmenjanssen]

I'm using this branch in Subsidieportaal. Let's see what happens.
If no notable errors happen in a month or so I'll merge this to master, bumping a major version (I don't want this to automatically propagate to every project).

[aapit]

Sounds good! David Spreekmeester Tech Lead | Grrr <http://grrr.nl/>

…

On 4 July 2017 at 10:31, Harmen Janssen ***@***.***> wrote: I'm using this branch in Subsidieportaal. Let's see what happens. If no notable errors happen in a month or so I'll merge this to master, bumping a major version (I don't want this to automatically propagate to every project). — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGEptbPQia1L-Db0iWksFaaScuOPcqBTks5sKfh8gaJpZM4MOSRF> .

[harmenjanssen]

Hmm, conclusions so far: it's a bit annoying to face warnings like "open basedir restriction in effect", when just asking if file_exists. They could've just chosen to return FALSE, and surely everything would just keep on working fine.

Anyways.

The current implementation has one fairly large disadvantage: because the exception comes from the error handler, they're sort of on a different track. Meaning, if I would wrap my entire app from start to finish in a try { ... } catch, I still would not be able to catch that exception. Unfortunately, that means Sentry won't pick up on it. So it needs further investigation. Maybe we could use set_exception_handler?

I've taken it out of Subsidieportaal for now, because Zend's cache helper does the aforementioned file_exists check. I don't know why yet, but pages using that helper would just bork completely.

[aapit]

I'm weeping with you and hope for improvement in the near future 🤓 David Spreekmeester Tech Lead | Grrr <http://grrr.nl/>

…

On 7 July 2017 at 22:20, Harmen Janssen ***@***.***> wrote: Hmm, conclusions so far: it's a bit annoying to face warnings like *"open basedir restriction in effect"*, when just asking if file_exists. They could've just chosen to return FALSE, and surely everything would just keep on working fine. Anyways. The current implementation has one fairly large disadvantage: because the exception comes from the error handler, they're sort of on a different track. Meaning, if I would wrap my entire app from start to finish in a try { ... } catch, I still would not be able to catch that exception. Unfortunately, that means Sentry won't pick up on it. So it needs further investigation. Maybe we could use set_exception_handler <http://php.net/manual/en/function.set-exception-handler.php>? I've taken it out of Subsidieportaal for now, because Zend's cache helper does the aforementioned file_exists check. I don't know why yet, but pages using that helper would just bork completely. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#30 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGEptedwQz0yjGWfR9xt1e5fIeAxhNMQks5sLpMKgaJpZM4MOSRF> .