Show/Hide elements based on consent #41
Conversation
After refactoring this module, the functionality of showing/hiding elements based on consent wasnt working anymore. However, this feature doesnt seem to be used at the moment, since this usually handled by the website that uses this module, by looking at changes in the consent. Nevertheless, the code in this module didn't work, so I fixed it, and also added tests for it, and cleaned up some code that wasnt doing anything usefull. AC-728
timoklok
force-pushed
the
feature/timo-ac728-show-content-on-consent
branch
from
72eea63 to
8a70477
Compare
| @@ -49,8 +49,6 @@ export default class Dialog extends HTMLElement { | |||
| // initialize show and hide | |||
| this.show = this.show(); | |||
| this.hide = this.hide(); | |||
| // get all preferences | |||
| this.preferences.getAll(); | |||
There was a problem hiding this comment.
The getAll() functions returns preferences. Running it without assigning it to a variable doesn't do anything.
| @@ -214,7 +210,7 @@ export default class Dialog extends HTMLElement { | |||
| } | |||
|
|
|||
| initDomToggler() { | |||
| return DomToggler(Config()); | |||
| return DomToggler(this.cookies); | |||
There was a problem hiding this comment.
the DomToggler was called with the wrong property. Config() doesn't actually return infomartion about the current state of cookies, only initial configuration data. Therefor, the Domtoggler couldn't show or hide elements based on consent, since there was no info about consent.
| @@ -103,7 +103,7 @@ const DomToggler = (config) => { | |||
|
|
|||
| return { | |||
| toggle: (preferences) => { | |||
| const cookies = config.get("cookies") || []; | |||
| const cookies = cookieData || []; | |||
There was a problem hiding this comment.
See previous comment
|
|
||
| expect(cookieConsent.preferences.getAll("foo")).toEqual(input); | ||
| cookieConsent.updatePreference(COOKIES); | ||
| expect(cookieConsent.preferences.getAll()).toEqual(COOKIES); |
There was a problem hiding this comment.
The test included code that didn't actually do anything. When the module is initialized, it actually doesn't set any localStorage values about cookies, that only happens when there has been interaction with the module.
So the test is also valid by just calling updatePreferences a single time.
After refactoring this module, the functionality of showing/hiding elements based on consent wasn't working anymore. Apparently this feature doesn't seem to be used at the moment, since this is usually handled by the website that implements this module, by looking at changes in the consent.
Nevertheless, the code in this module didn't work, so I fixed it, and also added tests for it, and cleaned up some code that wasn't doing anything useful.
AC-728