Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A73: Transport Selection #399

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

A73: Transport Selection #399

wants to merge 2 commits into from

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 7, 2023

No description provided.

(pending) [Call Semantics
Specification](https://github.com/grpc/grpc/pull/15460) and hide HTTP/2
semantics and grpc's wire protocol semantics.
1. Stream APIs should support object-based messages to facilitate an in-process
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the end, it seems you're expecting to make a copy here. I'd suggest mentioning copying objects as the alternative to serialize+deserialize. Otherwise it isn't really clear what you're talking about. On the face of it it looked like you'd just pass the object from client to server, but that is fundamentally broken unless the objects are immutable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned "copying".

clients and servers. The exact details will be left up to gRPC implementations
to decide; only the high-level method is included in this design.

Some additional design goals of this proposal:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awkward. It is in the proposal section, and defines a mix of goals and design choices. I think "goals" isn't the right word here, as these are part of the proposal itself. Goals shouldn't be in "Proposal" anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved into a sub-section about transports.

Copy link
Member Author

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated; PTAL

clients and servers. The exact details will be left up to gRPC implementations
to decide; only the high-level method is included in this design.

Some additional design goals of this proposal:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved into a sub-section about transports.

(pending) [Call Semantics
Specification](https://github.com/grpc/grpc/pull/15460) and hide HTTP/2
semantics and grpc's wire protocol semantics.
1. Stream APIs should support object-based messages to facilitate an in-process
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned "copying".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants