Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A61: IPv4 and IPv6 Dualstack Backend Support #356

Merged
merged 38 commits into from
Dec 16, 2023
Merged

A61: IPv4 and IPv6 Dualstack Backend Support #356

merged 38 commits into from
Dec 16, 2023

Conversation

markdroth
Copy link
Member

@markdroth markdroth commented Apr 20, 2023 •
edited
Loading

No description provided.

@markdroth markdroth mentioned this pull request Apr 21, 2023
Merged
@easwars easwars mentioned this pull request Apr 26, 2023
Closed
This was referenced Jul 24, 2023
Open
Closed
@murgatroid99 murgatroid99 mentioned this pull request Aug 30, 2023
Merged
@murgatroid99 murgatroid99 mentioned this pull request Sep 8, 2023
Merged
@ejona86 ejona86 mentioned this pull request Sep 21, 2023
Closed
@markdroth markdroth marked this pull request as ready for review October 2, 2023 15:17
@markdroth markdroth requested review from ejona86 and dfawley October 2, 2023 15:17
@ejona86 ejona86 mentioned this pull request Oct 6, 2023
Closed
@markdroth markdroth mentioned this pull request Nov 3, 2023
Open
@dfawley dfawley mentioned this pull request Dec 12, 2023
Closed
dfawley
dfawley approved these changes Dec 15, 2023
View reviewed changes
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
ejona86
ejona86 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No serious concerns. The outlier detection map could be discussed, but with something this large any detail like that is "minor."

A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
markdroth
markdroth commented Dec 16, 2023
View reviewed changes
Copy link
Member Author

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reviews!

A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
A61-IPv4-IPv6-dualstack-backends.md Outdated Show resolved Hide resolved
@markdroth markdroth merged commit 8a90dba into grpc:master Dec 16, 2023
1 check passed
@markdroth markdroth deleted the dualstack branch December 16, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larry-safran larry-safran larry-safran left review comments

@dfawley dfawley dfawley approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markdroth @ejona86 @dfawley @larry-safran