Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify codegen to use grpc_impl namespace and other cleanup #19435

Merged
merged 3 commits into from
Jun 24, 2019

Conversation

mhaidrygoog
Copy link
Member

Release Notes

This may break compilation if the user is not including server_context.h or client_context.h. In those cases please add the headers files "include/grpcpp/server_context.h" and "include/grpcpp/client_context.h"

@mhaidrygoog mhaidrygoog added lang/c++ lang/core release notes: yes Indicates if PR needs to be in release notes labels Jun 21, 2019
Copy link
Contributor

@karthikravis karthikravis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the unintended line..

@mhaidrygoog mhaidrygoog merged commit 2a589e2 into grpc:master Jun 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang/c++ lang/core release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants